Skip to content

Fix stale metadata for actions/create-github-app-token#652

Open
anthonymonori wants to merge 4 commits intorhysd:mainfrom
anthonymonori:update-creat-github-app-token-v-3-1-deprecated-setting
Open

Fix stale metadata for actions/create-github-app-token#652
anthonymonori wants to merge 4 commits intorhysd:mainfrom
anthonymonori:update-creat-github-app-token-v-3-1-deprecated-setting

Conversation

@anthonymonori
Copy link
Copy Markdown

@anthonymonori anthonymonori commented Apr 20, 2026

@v3 currently reflects the old v3.0.0 input shape, which causes false positives when workflows use client-id and the current moving v3 tag.

Example output (before changes in this PR):

$ actionlint .github/workflows/cherry-pick.yml
.github/workflows/cherry-pick.yml:91:15: missing input "app-id" which is required by action "actions/create-github-app-token@v3". all required inputs are "app-id", "private-key" [action]
.github/workflows/cherry-pick.yml:93:11: input "client-id" is not defined in action "actions/create-github-app-token@v3". available inputs are "app-id", ..., "private-key", ... [action]

actions/create-github-app-token@v3.1.0 release notes

This updates the popular actions registry and regenerates popular_actions.go so that:

  • actions/create-github-app-token@v3 matches the current upstream v3 metadata
  • actions/create-github-app-token@v3.0.0 is kept as a separate exact entry for workflows pinned to that version

Fixes #648

I've checked the CONTRIBUTIONS doc, ran linting, ran go generate (there actually was some other unrelated changes for aws-actions/configure-aws-credentials@v6 that i reverted since it's unrelated to this PR but just an FYI).

Let me know if I missed anything! 🙏 Or if you would prefer if we don't add the 3.0.0 regression case and just change the 1 line that's matters.

@anthonymonori
fix action metadata for create-github-app-token v3
cb23884 
Update actions/create-github-app-token@v3 so client-id is accepted and app-id is treated as deprecated instead of required.

Add a fixture covering the moving v3 tag with client-id.
@anthonymonori
add create-github-app-token v3.0.0 metadata
bb3de59 
Add an explicit actions/create-github-app-token@v3.0.0 entry to preserve the old input shape for workflows pinned to that exact version.

Add a fixture covering the exact ref with app-id.
@anthonymonori
generate metadata for create-github-app-token tags
c43d212 
Add create-github-app-token@v3.0.0 to the popular actions registry and regenerate popular_actions.go so the v3 entry matches the current upstream metadata while preserving the exact v3.0.0 shape.
@muzimuzhi
Copy link
Copy Markdown
Contributor

muzimuzhi commented Apr 20, 2026

Or if you would prefer if we don't add the 3.0.0 regression case and just change the 1 line that's matters.

I think the latter way is adopted in this repo.

BTW, input updates in popular_actions.go file can be auto-updated by the generate.yaml workflow, see for example #611.

But recently it failed because new releases of popular actions were detected but they were missing from the popular_actions.go:

[step] Check new release on GitHub
......
Detected some new releases
2026/04/18 02:04:56 Done detecting new versions in 99 repositories
https://github.com/actions/github-script/tree/v9
https://github.com/actions/upload-pages-artifact/tree/v5
https://github.com/dawidd6/action-download-artifact/tree/v20
https://github.com/softprops/action-gh-release/tree/v3
exit status 2
Error: Process completed with exit code 1.

https://github.com/rhysd/actionlint/actions/runs/24594466017/job/71921705206#step:4:207

@anthonymonori
keep create-github-app-token fix focused on v3
778f197 
Remove the exact v3.0.0 entry and fixture so this stays limited to the current actions/create-github-app-token@v3 metadata fix.
@anthonymonori
Copy link
Copy Markdown
Author

anthonymonori commented Apr 20, 2026 •
edited
Loading

Thanks @muzimuzhi for pointing that out. Was looking around how to address that issue as I ran into it locally, but I didn't see that we have a way to auto-update metadata.

I guess if that workflow would be fixed, we would get a PR that patches this change for v3 anyway? In that case, I'm happy to close this down and go that route. 🙏

In the meanwhile I also removed the regression case and reduced this PR to the minimal change in 778f197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

actions/create-github-app-token@v3 inputs changed

2 participants

@anthonymonori @muzimuzhi